EnricoMi commented on code in PR #54224:
URL: https://github.com/apache/spark/pull/54224#discussion_r2793972813
##########
core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala:
##########
@@ -193,40 +193,48 @@ class BlockManagerMaster(
/** Remove all blocks belonging to the given RDD. */
def removeRdd(rddId: Int, blocking: Boolean): Unit = {
- val future = driverEndpoint.askSync[Future[Seq[Int]]](RemoveRdd(rddId))
+ val msg = RemoveRdd(rddId)
+ val future = if (blocking) {
+ driverEndpoint.askSync[Future[Seq[Int]]](msg, waitBlockRemovalTimeout)
+ } else {
+ driverEndpoint.ask[Future[Seq[Int]]](msg)
+ }
Review Comment:
Ahh, `askSync` is a synchronous transfer of the `Future`, while the future
most likely is not completed. And `askSync(..., timeout)` is the timeout of the
sync transfer. Thanks for clarification!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
