dtenedor commented on code in PR #54231:
URL: https://github.com/apache/spark/pull/54231#discussion_r2795592877
##########
sql/api/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -3948,768 +3949,772 @@ object functions {
def raise_error(c: Column): Column = Column.fn("raise_error", c)
/**
- * Returns the estimated number of unique values given the binary
representation of a
- * Datasketches HllSketch.
+ * Returns the user name of current execution context.
*
* @group misc_funcs
* @since 3.5.0
*/
- def hll_sketch_estimate(c: Column): Column =
Column.fn("hll_sketch_estimate", c)
+ def user(): Column = Column.fn("user")
/**
- * Returns the estimated number of unique values given the binary
representation of a
- * Datasketches HllSketch.
+ * Returns the user name of current execution context.
*
* @group misc_funcs
- * @since 3.5.0
+ * @since 4.0.0
*/
- def hll_sketch_estimate(columnName: String): Column = {
- hll_sketch_estimate(Column(columnName))
- }
+ def session_user(): Column = Column.fn("session_user")
/**
- * Merges two binary representations of Datasketches HllSketch objects,
using a Datasketches
- * Union object. Throws an exception if sketches have different lgConfigK
values.
+ * Returns an universally unique identifier (UUID) string. The value is
returned as a canonical
+ * UUID 36-character string.
*
* @group misc_funcs
* @since 3.5.0
*/
- def hll_union(c1: Column, c2: Column): Column =
- Column.fn("hll_union", c1, c2)
+ def uuid(): Column = Column.fn("uuid", lit(SparkClassUtils.random.nextLong))
/**
- * Merges two binary representations of Datasketches HllSketch objects,
using a Datasketches
- * Union object. Throws an exception if sketches have different lgConfigK
values.
+ * Returns an universally unique identifier (UUID) string. The value is
returned as a canonical
+ * UUID 36-character string.
*
* @group misc_funcs
- * @since 3.5.0
+ * @since 4.1.0
*/
- def hll_union(columnName1: String, columnName2: String): Column = {
- hll_union(Column(columnName1), Column(columnName2))
- }
+ def uuid(seed: Column): Column = Column.fn("uuid", seed)
/**
- * Merges two binary representations of Datasketches HllSketch objects,
using a Datasketches
- * Union object. Throws an exception if sketches have different lgConfigK
values and
- * allowDifferentLgConfigK is set to false.
+ * Returns an encrypted value of `input` using AES in given `mode` with the
specified `padding`.
Review Comment:
@cboumalh There are a lot of diffs in this PR, making it somewhat difficult
to verify that the changes only affect the Datasketches functions, e.g.
<img width="1034" height="115" alt="image"
src="https://github.com/user-attachments/assets/0e48be08-ab48-45a2-8366-5da97c9c41a0";
/>
Do you think it could be possible to update the changes to avoid moving
existing functions around as much as possible such that the diffs only show
changes to function properties, rather than move invasive diffs of large blocks
of functions updated/changed? This would make it easier and safer to review 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
