heyihong commented on code in PR #54056:
URL: https://github.com/apache/spark/pull/54056#discussion_r2795181029
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -5487,6 +5409,149 @@
],
"sqlState" : "42601"
},
+ "SPARK_CONNECT_ILLEGAL_STATE" : {
+ "message" : [
+ "Spark Connect encountered an illegal state condition."
+ ],
+ "subClass" : {
+ "DATA_INTEGRITY_CHUNK_INDEX_MISMATCH" : {
Review Comment:
My understanding is that illegal state errors are rare and should only occur
when bugs are present. So, I was wondering whether it actually makes sense to
have a subclass for each illegal state message instead of just using a general
message \<msg\> (it may be a better idea to start with this). On the other
hand, I feel that testing for error conditions is lacking, especially if we
want to maintain so many different subclasses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
