dongjoon-hyun commented on code in PR #54299:
URL: https://github.com/apache/spark/pull/54299#discussion_r2801996588


##########
sql/core/src/main/scala/org/apache/spark/sql/classic/Dataset.scala:
##########
@@ -595,8 +595,7 @@ class Dataset[T] private[sql](
     val parsedDelay = IntervalUtils.fromIntervalString(delayThreshold)
     require(!IntervalUtils.isNegative(parsedDelay),
       s"delay threshold ($delayThreshold) should not be negative.")
-    EventTimeWatermark(util.UUID.randomUUID(), UnresolvedAttribute(eventTime),
-      parsedDelay, logicalPlan)
+    UnresolvedEventTimeWatermark(UnresolvedAttribute(eventTime), parsedDelay, 
logicalPlan)

Review Comment:
   This bug seems to be there before 4.1.0. Did I understand correctly?
   
   Do we have a backport plan? Or, we just introduce this as a new improvement 
at 4.2.0?
   
   <img width="798" height="290" alt="Image" 
src="https://github.com/user-attachments/assets/9fd5b074-0eda-48c4-ba85-d50683156843";
 />



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to