Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/6741#issuecomment-110824492
LGTM. @WangTaoTheTonic's comment was a little misleading since the previous
code would not add it to *all* classes, but to any classes that did not match
the pre-existing special cases. From the previous version:
*)
OUR_JAVA_OPTS="$SPARK_JAVA_OPTS"
OUR_JAVA_MEM=${SPARK_DRIVER_MEMORY:-$DEFAULT_MEM}
;;
BTW, given that code, the `else` should also probably do:
memKey = "SPARK_DRIVER_MEMORY";
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]