dongjoon-hyun commented on code in PR #54292:
URL: https://github.com/apache/spark/pull/54292#discussion_r2802120053
##########
core/benchmarks/LZFBenchmark-jdk21-results.txt:
##########
@@ -2,18 +2,18 @@
Benchmark LZFCompressionCodec
================================================================================================
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
AMD EPYC 7763 64-Core Processor
Compress small objects: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
--------------------------------------------------------------------------------------------------------------------------------
-Compression 256000000 int values in parallel 594 606
11 430.9 2.3 1.0X
-Compression 256000000 int values single-threaded 570 572
1 449.0 2.2 1.0X
+Compression 256000000 int values in parallel 604 611
9 423.7 2.4 1.0X
+Compression 256000000 int values single-threaded 560 561
2 457.5 2.2 1.1X
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
AMD EPYC 7763 64-Core Processor
Compress large objects: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
-----------------------------------------------------------------------------------------------------------------------------
-Compression 1024 array values in 2 threads 23 25
1 0.0 22108.7 1.0X
-Compression 1024 array values single-threaded 32 33
0 0.0 31296.0 0.7X
+Compression 1024 array values in 1 threads 47 54
4 0.0 45412.7 1.0X
Review Comment:
Ya, I agree with you. We may had better simply choose a constant value, `2`,
always.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]