dongjoon-hyun commented on code in PR #54313:
URL: https://github.com/apache/spark/pull/54313#discussion_r2805622739


##########
sql/core/benchmarks/ConstantColumnVectorBenchmark-jdk21-results.txt:
##########
@@ -1,280 +1,280 @@
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test write with StringType, row length = 1:  Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
--------------------------------------------------------------------------------------------------------------------------
-ConstantColumnVector                                    1              1       
    0     395190.2           0.0       1.0X
-OnHeapColumnVector                                   2762           2763       
    2        148.3           6.7       0.0X
-OffHeapColumnVector                                  5156           5167       
   16         79.4          12.6       0.0X
+ConstantColumnVector                                    1              1       
    0     371826.9           0.0       1.0X
+OnHeapColumnVector                                   2965           2966       
    1        138.1           7.2       0.0X
+OffHeapColumnVector                                  6430           6432       
    2         63.7          15.7       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test write with StringType, row length = 5:  Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
--------------------------------------------------------------------------------------------------------------------------
-ConstantColumnVector                                    1              1       
    0     422657.1           0.0       1.0X
-OnHeapColumnVector                                   3876           3876       
    0        105.7           9.5       0.0X
-OffHeapColumnVector                                  4578           4580       
    3         89.5          11.2       0.0X
+ConstantColumnVector                                    1              1       
    0     423706.0           0.0       1.0X
+OnHeapColumnVector                                   5336           5337       
    1         76.8          13.0       0.0X
+OffHeapColumnVector                                  5864           5865       
    0         69.8          14.3       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test write with StringType, row length = 10:  Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
---------------------------------------------------------------------------------------------------------------------------
-ConstantColumnVector                                     1              1      
     0     422963.1           0.0       1.0X
-OnHeapColumnVector                                    4005           4007      
     2        102.3           9.8       0.0X
-OffHeapColumnVector                                   5152           5154      
     4         79.5          12.6       0.0X
+ConstantColumnVector                                     1              1      
     0     423824.8           0.0       1.0X
+OnHeapColumnVector                                    5352           5353      
     2         76.5          13.1       0.0X
+OffHeapColumnVector                                   6304           6328      
    34         65.0          15.4       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test write with StringType, row length = 15:  Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
---------------------------------------------------------------------------------------------------------------------------
-ConstantColumnVector                                     1              1      
     0     422696.4           0.0       1.0X
-OnHeapColumnVector                                    4352           4361      
    13         94.1          10.6       0.0X
-OffHeapColumnVector                                   4869           4886      
    25         84.1          11.9       0.0X
+ConstantColumnVector                                     1              1      
     0     423864.3           0.0       1.0X
+OnHeapColumnVector                                    5759           5759      
     1         71.1          14.1       0.0X
+OffHeapColumnVector                                   6286           6290      
     5         65.2          15.3       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test write with StringType, row length = 20:  Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
---------------------------------------------------------------------------------------------------------------------------
-ConstantColumnVector                                     1              1      
     0     422775.4           0.0       1.0X
-OnHeapColumnVector                                    4334           4340      
     8         94.5          10.6       0.0X
-OffHeapColumnVector                                   4886           4886      
     1         83.8          11.9       0.0X
+ConstantColumnVector                                     1              1      
     0     423969.6           0.0       1.0X
+OnHeapColumnVector                                    6339           6340      
     2         64.6          15.5       0.0X
+OffHeapColumnVector                                   6752           6754      
     3         60.7          16.5       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test write with StringType, row length = 30:  Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
---------------------------------------------------------------------------------------------------------------------------
-ConstantColumnVector                                     1              1      
     0     422932.5           0.0       1.0X
-OnHeapColumnVector                                    4562           4563      
     2         89.8          11.1       0.0X
-OffHeapColumnVector                                   4860           4860      
     0         84.3          11.9       0.0X
+ConstantColumnVector                                     1              1      
     0     424049.0           0.0       1.0X
+OnHeapColumnVector                                    6184           6201      
    24         66.2          15.1       0.0X
+OffHeapColumnVector                                   6598           6599      
     2         62.1          16.1       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test write with IntegerType:              Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
------------------------------------------------------------------------------------------------------------------------
-ConstantColumnVector                                  1              1         
  0     664341.9           0.0       1.0X
-OnHeapColumnVector                                   16             16         
  0      25463.4           0.0       0.0X
-OffHeapColumnVector                                  66             66         
  0       6190.9           0.2       0.0X
+ConstantColumnVector                                  1              1         
  0     664346.2           0.0       1.0X
+OnHeapColumnVector                                   16             16         
  0      25222.9           0.0       0.0X
+OffHeapColumnVector                                  66             66         
  0       6236.8           0.2       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test write with LongType:                 Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
------------------------------------------------------------------------------------------------------------------------
-ConstantColumnVector                                  1              1         
  0     632708.0           0.0       1.0X
-OnHeapColumnVector                                   33             33         
  0      12470.4           0.1       0.0X
-OffHeapColumnVector                                  67             67         
  0       6152.8           0.2       0.0X
+ConstantColumnVector                                  1              1         
  0     632713.9           0.0       1.0X
+OnHeapColumnVector                                   34             35         
  0      11954.6           0.1       0.0X
+OffHeapColumnVector                                  68             68         
  0       6052.0           0.2       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test write with FloatType:                Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
------------------------------------------------------------------------------------------------------------------------
-ConstantColumnVector                                  1              1         
  0     457741.1           0.0       1.0X
-OnHeapColumnVector                                   16             16         
  0      25373.4           0.0       0.1X
-OffHeapColumnVector                                 129            129         
  0       3178.6           0.3       0.0X
+ConstantColumnVector                                  1              1         
  0     474071.3           0.0       1.0X
+OnHeapColumnVector                                   16             16         
  0      25044.5           0.0       0.1X
+OffHeapColumnVector                                 129            129         
  0       3175.9           0.3       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test write with DoubleType:               Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
------------------------------------------------------------------------------------------------------------------------
-ConstantColumnVector                                  1              1         
  0     510541.1           0.0       1.0X
-OnHeapColumnVector                                   33             34         
  0      12383.3           0.1       0.0X
-OffHeapColumnVector                                 129            129         
  0       3169.5           0.3       0.0X
+ConstantColumnVector                                  1              1         
  0     530959.2           0.0       1.0X
+OnHeapColumnVector                                   34             34         
  0      12123.0           0.1       0.0X
+OffHeapColumnVector                                 130            130         
  0       3159.6           0.3       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test read with StringType, row length = 1:  Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
-------------------------------------------------------------------------------------------------------------------------
-ConstantColumnVector                                   0              0        
   0   13274135.5           0.0       1.0X
-OnHeapColumnVector                                    99             99        
   0       4157.0           0.2       0.0X
-OffHeapColumnVector                                 6730           6738        
  11         60.9          16.4       0.0X
+ConstantColumnVector                                   0              0        
   0   13278438.7           0.0       1.0X
+OnHeapColumnVector                                   114            114        
   0       3599.9           0.3       0.0X
+OffHeapColumnVector                                 7297           7300        
   4         56.1          17.8       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test read with StringType, row length = 5:  Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
-------------------------------------------------------------------------------------------------------------------------
-ConstantColumnVector                                   0              0        
   0   13274135.5           0.0       1.0X
-OnHeapColumnVector                                  4072           4091        
  27        100.6           9.9       0.0X
-OffHeapColumnVector                                 6747           6747        
   0         60.7          16.5       0.0X
+ConstantColumnVector                                   0              0        
   0   13278438.7           0.0       1.0X
+OnHeapColumnVector                                  4367           4368        
   2         93.8          10.7       0.0X
+OffHeapColumnVector                                 7307           7316        
  13         56.1          17.8       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test read with StringType, row length = 10:  Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
--------------------------------------------------------------------------------------------------------------------------
 ConstantColumnVector                                    0              0       
    0   13274135.5           0.0       1.0X
-OnHeapColumnVector                                   4069           4076       
   10        100.7           9.9       0.0X
-OffHeapColumnVector                                  6733           6734       
    1         60.8          16.4       0.0X
+OnHeapColumnVector                                   4324           4325       
    3         94.7          10.6       0.0X
+OffHeapColumnVector                                  7301           7303       
    3         56.1          17.8       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test read with StringType, row length = 15:  Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
--------------------------------------------------------------------------------------------------------------------------
 ConstantColumnVector                                    0              0       
    0   13274135.5           0.0       1.0X
-OnHeapColumnVector                                   4079           4079       
    1        100.4          10.0       0.0X
-OffHeapColumnVector                                  6735           6736       
    3         60.8          16.4       0.0X
+OnHeapColumnVector                                   4332           4342       
   14         94.6          10.6       0.0X
+OffHeapColumnVector                                  7299           7302       
    4         56.1          17.8       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test read with StringType, row length = 20:  Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
--------------------------------------------------------------------------------------------------------------------------
 ConstantColumnVector                                    0              0       
    0   13274135.5           0.0       1.0X
-OnHeapColumnVector                                   4061           4063       
    2        100.9           9.9       0.0X
-OffHeapColumnVector                                  6728           6729       
    1         60.9          16.4       0.0X
+OnHeapColumnVector                                   4318           4323       
    6         94.9          10.5       0.0X
+OffHeapColumnVector                                  7306           7306       
    0         56.1          17.8       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test read with StringType, row length = 30:  Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
--------------------------------------------------------------------------------------------------------------------------
 ConstantColumnVector                                    0              0       
    0   13274135.5           0.0       1.0X
-OnHeapColumnVector                                   4076           4077       
    1        100.5          10.0       0.0X
-OffHeapColumnVector                                  6746           6759       
   18         60.7          16.5       0.0X
+OnHeapColumnVector                                   4320           4323       
    4         94.8          10.5       0.0X
+OffHeapColumnVector                                  7274           7277       
    3         56.3          17.8       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test read with IntegerType:               Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
------------------------------------------------------------------------------------------------------------------------
-ConstantColumnVector                                  0              0         
  0    3321467.1           0.0       1.0X
-OnHeapColumnVector                                    1              1         
  0     510969.1           0.0       0.2X
-OffHeapColumnVector                                 893            893         
  1        458.9           2.2       0.0X
+ConstantColumnVector                                  0              0         
  0   13274135.5           0.0       1.0X
+OnHeapColumnVector                                    1              1         
  0     531380.8           0.0       0.0X
+OffHeapColumnVector                                 894            894         
  0        458.3           2.2       0.0X
 
-OpenJDK 64-Bit Server VM 21.0.8+9-LTS on Linux 6.11.0-1018-azure
+OpenJDK 64-Bit Server VM 21.0.10+7-LTS on Linux 6.14.0-1017-azure
 AMD EPYC 7763 64-Core Processor
 Test read with LongType:                  Best Time(ms)   Avg Time(ms)   
Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 
------------------------------------------------------------------------------------------------------------------------
-ConstantColumnVector                               1839           1840         
  2        222.7           4.5       1.0X
-OnHeapColumnVector                                    0              0         
  0    1580533.5           0.0    7096.3X

Review Comment:
   Previous value `0` looks wrong to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to