sarutak commented on code in PR #54315:
URL: https://github.com/apache/spark/pull/54315#discussion_r2806144449
##########
core/src/main/scala/org/apache/spark/ui/DriverLogPage.scala:
##########
@@ -56,12 +56,12 @@ private[ui] class DriverLogPage(
</span>
val moreButton =
- <button type="button" onclick={"loadMore()"} class="log-more-btn btn
btn-secondary">
+ <button type="button" class="log-more-btn btn btn-secondary">
Load More
</button>
val newButton =
- <button type="button" onclick={"loadNew()"} class="log-new-btn btn
btn-secondary">
Review Comment:
No, `nonce` cannot be applied to inline event handlers like `onClick`. So
event handler bindings are moved to `*.js`. For example, the event handler
binding for this button is moved to
[here](https://github.com/apache/spark/pull/54315/changes#diff-e84842b7584608e837ab2dd6d06f75ac202fa91f34c37bd0f3f7808ec81d170dR151)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
