cloud-fan commented on code in PR #54236:
URL: https://github.com/apache/spark/pull/54236#discussion_r2813534236
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -1028,13 +1034,15 @@ object PushProjectionThroughUnion extends
Rule[LogicalPlan] {
}
def apply(plan: LogicalPlan): LogicalPlan = plan.transformWithPruning(
- _.containsAllPatterns(UNION, PROJECT)) {
+ t => t.containsPattern(PROJECT) &&
+ t.containsAnyPattern(UNION, SEQUENTIAL_STREAMING_UNION)) {
- // Push down deterministic projection through UNION ALL
- case project @ Project(projectList, u: Union)
+ // Push down deterministic projection through Union or
SequentialStreamingUnion.
+ // This is safe because it preserves child ordering.
+ case project @ Project(projectList, SequentialOrSimpleUnion(u))
if projectList.forall(_.deterministic) && u.children.nonEmpty &&
canPushProjectionThroughUnion(project) =>
- u.copy(children = pushProjectionThroughUnion(projectList, u))
+ SequentialOrSimpleUnion.withNewChildren(u,
pushProjectionThroughUnion(projectList, u))
Review Comment:
how about this
```
case project @ Project(projectList, sos @ SequentialOrSimpleUnion(u))
...
sos.withNewChildren(...)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
