HeartSaVioR commented on code in PR #54278:
URL: https://github.com/apache/spark/pull/54278#discussion_r2817253366
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBTimestampEncoderOperationsSuite.scala:
##########
@@ -281,6 +281,70 @@ class RocksDBTimestampEncoderOperationsSuite extends
SharedSparkSession
}
}
+ test(s"Event time as prefix: iterator with multiple values (encoding =
$encoding)") {
+ tryWithProviderResource(
+ newStoreProviderWithTimestampEncoder(
+ encoderType = "prefix",
+ useMultipleValuesPerKey = true,
+ dataEncoding = encoding)
+ ) { provider =>
+ val store = provider.getStore(0)
+
+ try {
+ // Put multiple values at different event times
+ // Insert in non-sorted order to verify ordering by event time
+ val values2 = Array(valueToRow(200), valueToRow(201))
+ store.putList(keyAndTimestampToRow("key1", 1, 1000L), values2)
Review Comment:
The test we added in encoder is extended to cover multi-values API as well.
Would it be sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
