heyihong commented on code in PR #54094:
URL: https://github.com/apache/spark/pull/54094#discussion_r2822581220
##########
sql/connect/common/src/main/protobuf/spark/connect/base.proto:
##########
@@ -491,6 +491,12 @@ message ExecutePlanResponse {
repeated Expression.Literal values = 2;
repeated string keys = 3;
int64 plan_id = 4;
+ // (Optional) The index of the root error in errors.
+ // The field will not be set if there are no errors.
+ optional int32 root_error_idx = 5;
Review Comment:
Having `root_error_idx` is more flexible and self-contained as part of the
protocol because it makes fewer assumptions about the order of errors. The
implementation does not need to place the error at the head of the list.
##########
sql/connect/common/src/main/protobuf/spark/connect/base.proto:
##########
@@ -491,6 +491,12 @@ message ExecutePlanResponse {
repeated Expression.Literal values = 2;
repeated string keys = 3;
int64 plan_id = 4;
+ // (Optional) The index of the root error in errors.
+ // The field will not be set if there are no errors.
+ optional int32 root_error_idx = 5;
Review Comment:
Having `root_error_idx` is more flexible and self-contained as part of the
protocol because it makes fewer assumptions about the order of errors. So the
implementation does not need to place the error at the head of the list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
