dongjoon-hyun commented on code in PR #53840:
URL: https://github.com/apache/spark/pull/53840#discussion_r2823659603
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala:
##########
@@ -158,8 +159,11 @@ private[spark] class KubernetesClusterManager extends
ExternalClusterManager wit
podsPollingEventSource)
}
- private[k8s] def makeExecutorPodsAllocator(sc: SparkContext,
kubernetesClient: KubernetesClient,
- snapshotsStore: ExecutorPodsSnapshotsStore) = {
+ private[k8s] def makeExecutorPodsAllocator(
+ sc: SparkContext,
+ kubernetesClient: KubernetesClient,
+ snapshotsStore: ExecutorPodsSnapshotsStore,
+ lifecycleManager: ExecutorPodsLifecycleManager) = {
Review Comment:
Shall we use the following style and minimize the change of
`KubernetesClusterManagerSuite`?
```scala
- lifecycleManager: ExecutorPodsLifecycleManager) = {
+ lifecycleManager: Option[ExecutorPodsLifecycleManager] = None) = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
