anishshri-db commented on code in PR #54277:
URL: https://github.com/apache/spark/pull/54277#discussion_r2823853945
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -2584,6 +2584,26 @@ object SQLConf {
.createWithDefault(
"org.apache.spark.sql.execution.streaming.state.HDFSBackedStateStoreProvider")
+ val STREAMING_CHECKPOINT_STATE_CREATE_METADATA_DIR_ON_READ =
+ buildConf("spark.sql.streaming.checkpoint.stateCreateMetadataDirOnRead")
Review Comment:
Why do we want to add a flag for this ?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/CommitLog.scala:
##########
@@ -46,8 +46,11 @@ import org.apache.spark.sql.internal.SQLConf
* line 1: version
* line 2: metadata (optional json string)
*/
-class CommitLog(sparkSession: SparkSession, path: String)
- extends HDFSMetadataLog[CommitMetadata](sparkSession, path) {
+class CommitLog(
+ sparkSession: SparkSession,
+ path: String,
+ readOnly: Boolean = false)
Review Comment:
Should we separate these 2 changes ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
