AlSchlo commented on code in PR #54368:
URL: https://github.com/apache/spark/pull/54368#discussion_r2824270623
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/vectorExpressions.scala:
##########
@@ -397,26 +375,17 @@ case class VectorAvg(
}
}
- // Aggregate buffer schema: (avg: BINARY, dim: INTEGER, count: LONG)
- // avg is a BINARY representation of the average vector of floats in the
group
- // dim is the dimension of the vector
- // count is the number of vectors in the group
- // null avg means no valid input has been seen yet
- private lazy val avgAttr = AttributeReference(
- "avg",
+ // Aggregate buffer schema: (current: BINARY, count: LONG)
Review Comment:
I feel like current is perhaps a slightly misleading name. It technically
could be the sum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
