peter-toth commented on PR #54330: URL: https://github.com/apache/spark/pull/54330#issuecomment-3926218509
> I think the coalesceRDD is a good idea, but its a bit risky I feel to change so much the DataSourceRDD. Is there another way? Maybe have a customRDD that holds the grouped partitions? though im not so familiar with this part Initially I wanted to add a new RDD for `GroupPartitionsExec` but it was very similar to `CoalescedRDD` / `CoalescedRDDPartition` so just creating a new `GroupedPartitionCoalescer` seemed like a cleaner approach. `DataSourceRDD` is now back to its pre partition grouping form. IMO we will need to backport the `ThreadLocal[ReaderState]` fix to previous Spark versions too so as to fix the case when there is a coalece after the scan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
