chris-twiner commented on PR #54366: URL: https://github.com/apache/spark/pull/54366#issuecomment-3927470953
> The added test case does not pass if the other change is removed. > > You could also add an assert https://github.com/apache/spark/blob/master/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala#L709 here that out it never null and that will not break any existing tests. lol, blame it on a caffeine deficit. Yeah that makes sense, it's interesting that it wasn't picked up by some of the frameless tests, I'm probably working around it without realising. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
