LuciferYang commented on code in PR #54446:
URL: https://github.com/apache/spark/pull/54446#discussion_r2846409400
##########
mllib/src/test/scala/org/apache/spark/ml/feature/CountVectorizerSuite.scala:
##########
@@ -350,4 +350,18 @@ class CountVectorizerSuite extends MLTest with
DefaultReadWriteTest {
assert(features === Vectors.sparse(0, Seq()))
}
}
+
+ test("SPARK-55655: CountVectorizer vocabulary ordering is deterministic for
tied counts") {
+ val df = Seq(
+ (0, split("a b c d e")),
+ (1, split("e d c b a"))
+ ).toDF("id", "words")
+
+ val cvModel = new CountVectorizer()
+ .setInputCol("words")
+ .setOutputCol("features")
+ .fit(df)
+
+ assert(cvModel.vocabulary === Array("a", "b", "c", "d", "e"))
Review Comment:
Before this pr, this test would fail:
```
[info] - SPARK-55655: CountVectorizer vocabulary ordering is deterministic
for tied counts *** FAILED *** (33 milliseconds)
[info] Array("d", "e", "b", "a", "c") did not equal Array("a", "b", "c",
"d", "e") (CountVectorizerSuite.scala:365)
[info] org.scalatest.exceptions.TestFailedException:
[info] at
org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info] at
org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
[info] at
org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
[info] at
org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
[info] at
org.apache.spark.ml.feature.CountVectorizerSuite.$anonfun$new$30(CountVectorizerSuite.scala:365)
[info] at
org.scalatest.enablers.Timed$$anon$1.timeoutAfter(Timed.scala:127)
[info] at
org.scalatest.concurrent.TimeLimits$.failAfterImpl(TimeLimits.scala:282)
[info] at
org.scalatest.concurrent.TimeLimits.failAfter(TimeLimits.scala:231)
[info] at
org.scalatest.concurrent.TimeLimits.failAfter$(TimeLimits.scala:230)
[info] at org.apache.spark.SparkFunSuite.failAfter(SparkFunSuite.scala:30)
[info] at
org.apache.spark.SparkFunSuite.$anonfun$test$2(SparkFunSuite.scala:41)
[info] at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info] at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[info] at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info] at org.scalatest.Transformer.apply(Transformer.scala:22)
[info] at org.scalatest.Transformer.apply(Transformer.scala:20)
[info] at
org.scalatest.funsuite.AnyFunSuiteLike$$anon$1.apply(AnyFunSuiteLike.scala:226)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
