yaooqinn opened a new pull request, #54589:
URL: https://github.com/apache/spark/pull/54589

   ### What changes were proposed in this pull request?
   
   Replace full-page navigation for Thread Dump and Heap Histogram executor 
details with Bootstrap 5 Offcanvas slide-out panels on the Executors page.
   
   **Changes:**
   - **ExecutorsTab.scala**: Added BS5 Offcanvas markup (60vw wide, right-side 
slide-out panel)
   - **executorspage.js**: Added `openDetailOffcanvas(url, title)` function 
that:
     - Shows a loading spinner while fetching content
     - AJAX-fetches the existing detail page HTML
     - Extracts the content via DOMParser
     - Injects it into the offcanvas body
     - Re-initializes BS5 tooltips and sorttable for injected content
     - Falls back to an error message with link to open in new page
   - Changed Thread Dump and Heap Histogram links from `<a href>` to `onclick` 
offcanvas triggers
   
   ### Why are the changes needed?
   
   Part of the Spark Web UI Modernization 
([SPARK-55760](https://issues.apache.org/jira/browse/SPARK-55760)). The 
executor detail pages (Thread Dump, Heap Histogram) currently navigate away 
from the Executors list page. Using BS5 Offcanvas panels keeps the user in 
context:
   1. No page navigation — detail info slides in from the right
   2. Quick comparison between executors without navigating back and forth
   3. Modern UX pattern consistent with BS5 adoption
   4. The existing detail pages remain accessible via direct URLs
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Clicking "Thread Dump" or "Heap Histogram" on the Executors page now 
opens a slide-out panel instead of navigating to a separate page. The detail 
pages remain accessible via direct URL.
   
   ### How was this patch tested?
   
   - Scalastyle checks pass
   - JS lint checks pass
   - Compilation succeeds
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Yes, GitHub Copilot CLI was used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to