dongjoon-hyun commented on code in PR #54622:
URL: https://github.com/apache/spark/pull/54622#discussion_r2884502405
##########
core/src/main/scala/org/apache/spark/ui/UIUtils.scala:
##########
@@ -546,22 +546,28 @@ private[spark] object UIUtils extends Logging {
def tooltip(text: String, position: String): Seq[Node] = {
<sup>
- (<a data-bs-toggle="tooltip" data-bs-placement={position}
title={text}>?</a>)
+ (<a data-bs-toggle="tooltip" title={text}>?</a>)
</sup>
}
/** Wrap content in a span with a Bootstrap 5 tooltip. */
def tooltipSpan(content: Seq[Node], text: String,
placement: String = "top"): Seq[Node] = {
- <span data-bs-toggle="tooltip" data-bs-placement={placement} title={text}>
+ val bsPlacement =
+ if (placement == "top") null else placement
Review Comment:
Could you make it one-liner?
```scala
- val bsPlacement =
- if (placement == "top") null else placement
+ val bsPlacement = if (placement == "top") null else placement
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
