yaooqinn opened a new pull request, #54639:
URL: https://github.com/apache/spark/pull/54639

   ### What changes were proposed in this pull request?
   
   Replaces the blocking browser `alert()` call with a Bootstrap 5 Toast 
notification.
   
   **Changes (2 files):**
   - **webui.js**: Added reusable `showToast(message, type)` function that 
creates a BS5 Toast in a fixed top-right container. Supports 
`danger`/`warning`/`success`/`info` types. Toasts auto-remove from DOM after 
dismissal.
   - **stagepage.js**: Replaced server connection error `alert()` with 
`showToast(..., "warning")` — non-blocking, dismissible, styled.
   
   ### Why are the changes needed?
   
   Browser `alert()` is blocking — it freezes the entire page until dismissed. 
BS5 Toasts are non-blocking, styled consistently with the rest of the UI, and 
dismissible. Part of SPARK-55760 (Spark Web UI Modernization).
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes — server connection errors on the stage page now show as a top-right 
Toast notification instead of a browser alert dialog.
   
   ### How was this patch tested?
   
   `lint-js` passes.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Yes, co-authored with GitHub Copilot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to