gengliangwang commented on PR #54667: URL: https://github.com/apache/spark/pull/54667#issuecomment-4019489561
@huan233usc please check the comment > Consider placing this conversion logic in the V2 code path (e.g., in DataSourceV2Relation or a V2 utility) rather than on the V1 catalog classes themselves. CatalogStatistics and CatalogColumnStat are V1 catalog constructs — having them depend on V2 interfaces (connector.read.Statistics, ColumnStatistics, FieldReference) couples the V1 catalog layer to the V2 connector API. The existing toPlanStats converts to the internal Statistics type, which is a natural dependency; V2 connector types are not. Keeping the conversion in the V2 layer would mirror how DataSourceV2Relation.transformV2Stats already handles the reverse direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
