Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/6724#discussion_r32180994
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -230,12 +230,24 @@ abstract class UnaryExpression extends Expression
with trees.UnaryNode[Expressio
val eval = child.gen(ctx)
// reuse the previous isNull
ev.isNull = eval.isNull
- eval.code + s"""
- ${ctx.javaType(dataType)} ${ev.primitive} =
${ctx.defaultValue(dataType)};
- if (!${ev.isNull}) {
- ${ev.primitive} = ${f(eval.primitive)};
- }
- """
+ child match {
+ case Literal(null, _) =>
--- End diff --
Without this change, it will throws exception
```
Code generation of strlen(null) failed:
[info]
[info] int primitive1 = -1;
[info] if (!true) {
[info] primitive1 = (null).length();
[info] }
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
