gaogaotiantian commented on code in PR #54763:
URL: https://github.com/apache/spark/pull/54763#discussion_r2922328730
##########
python/pyspark/sql/classic/dataframe.py:
##########
@@ -1086,10 +1088,12 @@ def groupBy(self, *cols: "ColumnOrNameOrOrdinal") ->
"GroupedData":
...
@overload
- def groupBy(self, __cols: Union[List[Column], List[str], List[int]]) ->
"GroupedData":
+ def groupBy(self, __cols: Sequence["ColumnOrNameOrOrdinal"]) ->
"GroupedData":
Review Comment:
`Sequence` has its well-defined protocol so we can just support that. We can
either convert it to a list or just loop over it. We should not care whether
it's a list or a tuple, as long as we can make it a list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
