liviazhu commented on code in PR #54381:
URL: https://github.com/apache/spark/pull/54381#discussion_r2926805531
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/HDFSMetadataLog.scala:
##########
@@ -48,7 +48,10 @@ import org.apache.spark.util.Utils
* Note: [[HDFSMetadataLog]] doesn't support S3-like file systems as they
don't guarantee listing
* files in a directory always shows the latest files.
*/
-class HDFSMetadataLog[T <: AnyRef : ClassTag](sparkSession: SparkSession,
path: String)
+class HDFSMetadataLog[T <: AnyRef : ClassTag](
+ sparkSession: SparkSession,
+ path: String,
+ readOnly: Boolean = false)
Review Comment:
same as above
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/CommitLog.scala:
##########
@@ -46,8 +46,11 @@ import org.apache.spark.sql.internal.SQLConf
* line 1: version
* line 2: metadata (optional json string)
*/
-class CommitLog(sparkSession: SparkSession, path: String)
- extends HDFSMetadataLog[CommitMetadata](sparkSession, path) {
+class CommitLog(
+ sparkSession: SparkSession,
+ path: String,
+ readOnly: Boolean = false)
Review Comment:
No. This class doesn't get serialized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
