Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6724#discussion_r32186366
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -90,4 +90,24 @@ class DataFrameFunctionsSuite extends QueryTest {
testData2.select(bitwiseNOT($"a")),
testData2.collect().toSeq.map(r => Row(~r.getInt(0))))
}
+
+ test("length") {
+ checkAnswer(
+ nullStrings.select(strlen($"s"), strlen("s")),
--- End diff --
for future ones, i prefer just having the data defined inline here. and
just have one or two items in the test data set. and we should explicitly put
in the test result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
