srielau commented on code in PR #54781:
URL: https://github.com/apache/spark/pull/54781#discussion_r2935432224
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -108,6 +108,12 @@ trait FunctionRegistryBase[T] {
/** Drop a function and return whether the function existed. */
def dropFunction(name: FunctionIdentifier): Boolean
+ /**
+ * Remove all cached function entries in the given database.
+ * Keeps the cache coherent when a database is dropped.
+ */
+ def dropFunctionsInDatabase(db: String): Unit
Review Comment:
FunctionRegistry.scala — Changed the trait method signature from
dropFunctionsInDatabase(db: String) to dropFunctionsInDatabase(namespace:
FunctionIdentifier), and updated all three implementations:
FunctionRegistryBase: Updated trait definition and doc comment
SimpleFunctionRegistryBase: Filters by both database (case-insensitive) and
catalog (when specified in the namespace), consistent with the
SESSION_NAMESPACE_TEMPLATE / BUILTIN_NAMESPACE_TEMPLATE pattern already used in
SessionCatalog
EmptyFunctionRegistryBase: Updated signature (still a no-op)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
