sarutak commented on code in PR #54676:
URL: https://github.com/apache/spark/pull/54676#discussion_r2935509221
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala:
##########
@@ -418,10 +418,28 @@ case class Cosh(child: Expression) extends
UnaryMathExpression(math.cosh, "COSH"
since = "3.0.0",
group = "math_funcs")
case class Acosh(child: Expression)
- extends UnaryMathExpression((x: Double) => StrictMath.log(x + math.sqrt(x *
x - 1.0)), "ACOSH") {
+ extends UnaryMathExpression((x: Double) => x match {
+ // in case of large values, the square would lead to Infinity; also, - 1
would be ignored due
+ // to numeric precision. So log(x + sqrt(x * x - 1)) becomes log(2x) =
log(2) + log(x) for
+ // positive values.
+ case x if x >= Math.sqrt(Double.MaxValue) =>
Review Comment:
@mgaido91
In the future, Java will provide native `asinh` and `acosh` which are based
on `fdlibm`.
https://bugs.openjdk.org/browse/JDK-8375285
https://bugs.openjdk.org/browse/JDK-8376665
So, should we choose `2^28` as the threshold rather than
`Math.sqrt(Double.MaxValue)` to align with `fdlibm` in a followup PR?
cc: @HyukjinKwon @peter-toth and @xiaoxuandev from #54677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
