Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6754#discussion_r32192107
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/MathExpressionsSuite.scala ---
    @@ -211,4 +236,18 @@ class MathExpressionsSuite extends QueryTest {
         testOneToOneNonNegativeMathFunction(log1p, math.log1p)
       }
     
    +  test("log2") {
    +    val df = Seq((1, 2)).toDF("a", "b")
    --- End diff --
    
    I think it makes sense to put all math stuff in here, all string stuff into 
its own suite, etc
    
    basically if we group expressions into files; we should also group test 
suites in the same way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to