Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6755#discussion_r32197095
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/BaseRow.java ---
@@ -154,6 +154,27 @@ public int fieldIndex(String name) {
throw new UnsupportedOperationException();
}
+ /**
+ * A generic version of Row.equals(Row), which is used for tests.
+ */
+ @Override
+ public boolean equals(Object other) {
+ if (other instanceof Row) {
+ Row row = (Row) other;
+ int n = size();
+ if (n != row.size()) {
+ return false;
+ }
+ for (int i = 0; i < n; i ++) {
+ if (isNullAt(i) != row.isNullAt(i) || !isNullAt(i) &&
!get(i).equals(row.get(i))) {
--- End diff --
+1 on adding parentheses.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
