Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6754#discussion_r32208862
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -653,6 +654,27 @@ trait HiveTypeCoercion {
}
/**
+ * Coerces the type of different branches of If statement to a common
type.
+ */
+ object IfCoercion extends Rule[LogicalPlan] {
+ def apply(plan: LogicalPlan): LogicalPlan = plan
transformAllExpressions {
+ // Find tightest common type for If, if the true value and false
value have different types.
+ case i @ If(pred, left, right) if left.dataType != right.dataType =>
+ findTightestCommonTypeOfTwo(left.dataType, right.dataType).map {
widestType =>
--- End diff --
i think we can define new TypeConversion class for Coalesce, If, CaseWhen,
and so on. because in Hive these udf function use same one type Conversion rule
as
https://github.com/apache/hive/blob/ac755ebe26361a4647d53db2a28500f71697b276/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java#L79.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
