Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6674#discussion_r32250114
  
    --- Diff: project/SparkBuild.scala ---
    @@ -51,6 +51,11 @@ object BuildCommons {
       // Root project.
       val spark = ProjectRef(buildLocation, "spark")
       val sparkHome = buildLocation
    +
    +  val testTempDir = s"$sparkHome/target/tmp"
    +  if (!new File(testTempDir).isDirectory()) {
    +    require(new File(testTempDir).mkdirs())
    +  }
    --- End diff --
    
    The problem with doing it this way is that `buildLocation` is just using 
the current directory as the build root, which is not always a valid 
assumption.  We should instead remove that `val` and use `projectRoot.value` 
anyplace that we need the root spark directory.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to