Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6725#discussion_r32275133
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -254,3 +254,54 @@ case class Pow(left: Expression, right: Expression)
"""
}
}
+
+object Logarithm {
+ def apply(child: Expression): Expression = new Log(child)
+}
+
+case class Logarithm(left: Expression, right: Expression)
+ extends BinaryMathExpression((c1, c2) => math.log(c2) / math.log(c1),
"LOG") {
+ override def eval(input: Row): Any = {
+ val evalE2 = right.eval(input)
+ if (evalE2 == null) {
+ null
+ } else {
+ val evalE1 = left.eval(input)
+ var result: Double = 0.0
+ if (evalE1 == null) {
+ result = math.log(evalE2.asInstanceOf[Double])
--- End diff --
Is it standard to assume base 10 if the exponent is null?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
