haiyangsun-db commented on code in PR #55611: URL: https://github.com/apache/spark/pull/55611#discussion_r3168787729
########## sql/core/src/main/scala/org/apache/spark/sql/execution/externalUDF/ExternalUDFExec.scala: ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.externalUDF + +import org.apache.spark.TaskContext +import org.apache.spark.annotation.Experimental +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.expressions.{Attribute, AttributeSet, ExternalUDFExpression} +import org.apache.spark.sql.execution.UnaryExecNode +import org.apache.spark.sql.execution.metric.{SQLMetric, SQLMetrics} +import org.apache.spark.udf.worker.UDFWorkerSpecification +import org.apache.spark.udf.worker.core.{WorkerSecurityScope, WorkerSession, WorkerSessionFactory} + +/** + * :: Experimental :: + * Base trait for physical plan nodes that execute UDFs in an external + * worker process via the language-agnostic UDF worker framework. + */ +@Experimental +trait ExternalUDFExec extends UnaryExecNode { + + /** Specification describing how to create and communicate with the UDF worker. */ + def workerSpec: UDFWorkerSpecification + + /** The UDF expression describing the function to execute. */ + def functionExpr: ExternalUDFExpression Review Comment: same here. Also how do you plan to express multiple UDFs (for single udf cases) in the same node with one single functionExpr? I can imagine that we might compact chained UDFs into one single expressions (where inner udf calls are leaf expression nodes), but we coul still have parallel UDF expressions that generate multiple outputs. For example: `select foo(bar(col1)), baz(col2) from some_table`, you may have one udf node that contains two UDF expressions: 1 representing `foo(bar(col1)`, while the other represents `baz(col2)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
