aokolnychyi commented on code in PR #55586: URL: https://github.com/apache/spark/pull/55586#discussion_r3174402985
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/InsertSummary.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.write; + +import org.apache.spark.annotation.Evolving; + +/** + * Provides an informational summary of the INSERT operation producing write. + * + * @since 4.2.0 + */ +@Evolving +public interface InsertSummary extends WriteSummary { + + /** + * Returns the number of output rows, or -1 if not found. + */ + long numOutputRows(); Review Comment: Would calling this `numInsertedRows` be more consistent with the rest of summaries? ########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala: ########## @@ -157,7 +157,11 @@ case class AppendData( isByName: Boolean, withSchemaEvolution: Boolean, write: Option[Write] = None, - analyzedQuery: Option[LogicalPlan] = None) extends V2WriteCommand with TransactionalWrite { + analyzedQuery: Option[LogicalPlan] = None, + rowLevelCommand: Option[RowLevelOperation.Command] = None) Review Comment: How do you feel about adding a new node like `InsertOnlyMerge` and `InsertOnlyMergeExec` instead of making `AppendData` that is heavily used aware of the row-level operation? I vibecoded it locally and it is fairly easy. ########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala: ########## @@ -157,7 +157,11 @@ case class AppendData( isByName: Boolean, withSchemaEvolution: Boolean, write: Option[Write] = None, - analyzedQuery: Option[LogicalPlan] = None) extends V2WriteCommand with TransactionalWrite { + analyzedQuery: Option[LogicalPlan] = None, + rowLevelCommand: Option[RowLevelOperation.Command] = None) Review Comment: I don't feel strongly here. More like 60/40 to have a new node, to be honest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
