franciscoabsampaio commented on PR #55648: URL: https://github.com/apache/spark/pull/55648#issuecomment-4372653618
Hi First time reviewing a PR. Before any ado, thanks for the contribution. Firstly, I'm concerned with the lack of documentation - this is a rather large feature. Secondly, upon very brief inspection, I see some patterns that I don't find anywhere else in the spark codebase, namely, the usage of `asyncio.to_thread()`. Like gaogaotiantian mentioned, this most likely needs a SPIP first. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
