cloud-fan commented on code in PR #55599:
URL: https://github.com/apache/spark/pull/55599#discussion_r3184852962
##########
python/pyspark/sql/functions/__init__.py:
##########
@@ -470,6 +470,7 @@
"schema_of_json",
"to_json",
# VARIANT Functions
+ "is_valid_variant",
Review Comment:
Adding `is_valid_variant` to `__all__` here is good, but the matching
`autosummary` entry in `python/docs/source/reference/pyspark.sql/functions.rst`
(right next to `is_variant_null` at line 589) was missed — without it the
function won't be picked up by Sphinx and won't appear in the rendered PySpark
function reference. Peer additions (e.g. `to_variant_object` in SPARK-49443)
added the rst entry in the same PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]