Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6747#discussion_r32286743
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -294,7 +501,31 @@ private[sql] class SQLConf extends Serializable with
CatalystConf {
* Return the value of Spark SQL configuration property for the given
key. If the key is not set
* yet, return `defaultValue`.
*/
- def getConf(key: String, defaultValue: String): String = {
+ def getConf[T](entry: SQLConfEntry[T], defaultValue: T): T = {
+ require(sqlConfEntries.get(entry.key) == entry, s"$entry is not
registered")
+
Option(settings.get(entry.key)).map(entry.valueConverter).getOrElse(defaultValue)
+ }
+
+ /**
+ * Return the value of Spark SQL configuration property for the given
key. If the key is not set
+ * yet, return `defaultValue` in [[SQLConfEntry]].
+ */
+ def getConf[T](entry: SQLConfEntry[T]): T = {
--- End diff --
What about just having a `.value` method on the Conf entry itself?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
