zhengruifeng opened a new pull request, #55709:
URL: https://github.com/apache/spark/pull/55709
### What changes were proposed in this pull request?
Removes a few redundant trait mixins in the test hierarchy:
1. `trait QueryTest extends SparkFunSuite with QueryTestBase with PlanTest`
— drop `with PlanTest`. `PlanTest` is `SparkFunSuite with PlanTestBase`, both
already in the linearization (`SparkFunSuite` is the first parent;
`QueryTestBase` already extends `PlanTestBase`). The mixin contributes nothing.
2. Concrete suites that already inherit `SQLHelper` transitively but
redeclared it:
- `SqlResourceWithActualMetricsSuite` (via `SharedSparkSession`)
- `SparkSessionExtensionSuite` (via `PlanTest`)
- `SQLQueryTestSuite` (via `SharedSparkSession`)
- `QueryParsingErrorsSuite` (via `SharedSparkSession`)
- `ClientE2ETestSuite` (via Connect's `QueryTest`)
The now-unused `SQLHelper` imports are also removed.
### Why are the changes needed?
Cleanup. Redundant mixins make the trait hierarchy harder to read and signal
confusion about where helpers come from.
### Does this PR introduce _any_ user-facing change?
No. Test-only refactor.
### How was this patch tested?
`build/sbt sql/Test/compile connect-client-jvm/Test/compile` succeeds. No
behavior change.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
