LuciferYang commented on PR #55628: URL: https://github.com/apache/spark/pull/55628#issuecomment-4395521410
> Ara you asking if we could enable it by default? IMO we could as it can only improve query plans. But in most scenarios (like in the case of TPCDS queries) `spark.sql.optimizer.mergeSubplans.filterPropagation.symmetricFilterPropagation.enabled=true` is also required, which might cause degradation in certain cases. > > Actually, there is typo in the PR description. The user facing section references the old name of the config (`spark.sql.optimizer.mergeSubplans.filterPropagation.filterPropagationThroughJoin.enabled`) unfortunately. Yeah, I meant that typo. Sorry I quoted the wrong content earlier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
