XdithyX commented on code in PR #55655:
URL: https://github.com/apache/spark/pull/55655#discussion_r3202873705
##########
sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/allexecutionspage.js:
##########
@@ -195,7 +195,13 @@ $(document).ready(function () {
data: "duration", name: "duration", title: "Duration",
render: function (data, type) {
if (type !== "display") return data;
- return formatDurationSql(data);
+ var formatted = formatDurationSql(data);
+ if (data > 600000) {
Review Comment:
@sarutak @yaooqinn I like the Pn based approach as well. Yes, maybe we can
combine relative thresholds with the current absolute thresholds as floor
values.
Eg
```
warning: max(P90(current page), 1min)
danger: max(P99(current page), 10min)
```
We could also fallback to the existing absolute thresholds when the current
page has only a small number of rows, since percentiles become less meaningful
on very small samples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
