johanl-db commented on code in PR #55637:
URL: https://github.com/apache/spark/pull/55637#discussion_r3217315586
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/Changelog.java:
##########
@@ -33,8 +33,12 @@
* <ul>
* <li>{@code _change_type} (STRING) — the kind of change: {@code insert},
{@code delete},
* {@code update_preimage}, or {@code update_postimage}</li>
- * <li>{@code _commit_version} (connector-defined type, e.g. LONG) — the
version containing
- * this change</li>
+ * <li>{@code _commit_version} — the commit version containing this change.
Must be of
+ * an atomic orderable type (e.g. {@code LongType}, {@code StringType},
Review Comment:
You're right. I think it's fine for now. If a connector needs to define
versions in the future that aren't trivially orderable, we may need to extend
the ChangeLog interface to let the connector define that ordering. We don't
need to do that now though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
