zhengruifeng opened a new pull request, #55809: URL: https://github.com/apache/spark/pull/55809
### What changes were proposed in this pull request? Drop the redundant `SparkFunSuite` term from `extends SparkFunSuite with SharedSparkSession` (and its multi-line variants) across 18 test suites, and remove the now-unused `SparkFunSuite` imports. Affected files: - `connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroCatalystDataConversionSuite.scala` - `connector/protobuf/src/test/scala/org/apache/spark/sql/protobuf/ProtobufCatalystDataConversionSuite.scala` - `sql/connect/server/src/test/scala/org/apache/spark/sql/connect/ProtoToParsedPlanTestSuite.scala` - `sql/connect/server/src/test/scala/org/apache/spark/sql/connect/service/RequestDecompressionInterceptorSuite.scala` - `sql/connect/server/src/test/scala/org/apache/spark/sql/connect/service/SparkConnectListenerBusListenerSuite.scala` - `sql/core/src/test/scala/org/apache/spark/sql/CacheManagerSuite.scala` - `sql/core/src/test/scala/org/apache/spark/sql/RowSuite.scala` - `sql/core/src/test/scala/org/apache/spark/sql/ScalaReflectionRelationSuite.scala` - `sql/core/src/test/scala/org/apache/spark/sql/SerializationSuite.scala` - `sql/core/src/test/scala/org/apache/spark/sql/collation/CollationExpressionWalkerSuite.scala` - `sql/core/src/test/scala/org/apache/spark/sql/execution/AggregatingAccumulatorSuite.scala` - `sql/core/src/test/scala/org/apache/spark/sql/execution/UnsafeKVExternalSorterSuite.scala` - `sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcTaskInterruptSuite.scala` - `sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/FileStreamSinkLogSuite.scala` - `sql/core/src/test/scala/org/apache/spark/sql/expressions/ExpressionInfoSuite.scala` - `sql/core/src/test/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNodeSuite.scala` - `sql/core/src/test/scala/org/apache/spark/sql/streaming/CommitLogSuite.scala` - `sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperationSuite.scala` `UnsafeKVExternalSorterSuite` uses `import org.apache.spark._` (wildcard), so only its extends clause changes; its imports are untouched. ### Why are the changes needed? `SharedSparkSession` transitively extends `SparkFunSuite`: ```scala trait SharedSparkSession extends QueryTest with SharedSparkSessionBase // and: abstract class QueryTest extends SparkFunSuite with QueryTestBase ``` so an explicit `extends SparkFunSuite with SharedSparkSession` on each suite is redundant. Dropping it reduces noise and lowers the chance of the pattern being copied into new suites. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests; the following SBT test compiles pass cleanly on the affected sources: - `build/sbt sql/Test/compile` - `build/sbt connect/Test/compile` - `build/sbt protobuf/Test/compile` - `build/sbt avro/Test/compile` - `build/sbt -Phive-thriftserver hive-thriftserver/Test/compile` ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
