uros-db commented on PR #54328: URL: https://github.com/apache/spark/pull/54328#issuecomment-4438272036
Actually, I'll go ahead and close this PR. As you pointed out, the SRID validation in Geometry.java / Geography.java is redundant, given that every production caller in STUtils already validates the SRID and throws ST_INVALID_SRID_VALUE before delegating to these wrappers. The cleaner approach overall is to just keep SRID validation at the user-facing API boundary (which is already where it lives) and not duplicate it in the catalyst-internal wrapper. Thanks @cloud-fan! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
