szehon-ho commented on PR #55493:
URL: https://github.com/apache/spark/pull/55493#issuecomment-4451360939

   ### Type checkers / IDE support
   
   Injected `spark` is easy to use at runtime, but mypy, pyright, and many 
editors will still treat `spark` as an undefined name unless users add a hint.
   
   **Suggestion:** In `docs/declarative-pipelines-programming-guide.md`, at the 
end of **“The Spark Session in Python Pipelines”** (after the 
`SparkSession.active()` paragraph), add one short sentence plus an optional 
fenced example—for example, that users can add `spark: SparkSession` at module 
scope after imports, noting that SDP injects the real session before the module 
body runs so this only documents the type for static analysis.
   
   ### Formatting
   
   +1 to @gengliangwang’s nit on **`APITest.scala`**: remove the extra blank 
line between the new backward-compat test and the following test so spacing 
matches the rest of the file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to