uros-db commented on code in PR #54950:
URL: https://github.com/apache/spark/pull/54950#discussion_r3241933136
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala:
##########
@@ -1806,7 +1815,7 @@ object TypeCoercionSuite {
val fractionalTypes: Seq[DataType] =
Seq(DoubleType, FloatType, DecimalType.SYSTEM_DEFAULT, DecimalType(10, 2))
val numericTypes: Seq[DataType] = integralTypes ++ fractionalTypes
- val datetimeTypes: Seq[DataType] = Seq(DateType, TimestampType,
TimestampNTZType)
+ val datetimeTypes: Seq[DataType] = Seq(DateType, TimestampType,
TimestampNTZType, TimeType())
Review Comment:
Reverted datetimeTypes to Seq(DateType, TimestampType, TimestampNTZType) and
restricted the new TimeType test's castable set to Seq(checkedType,
StringType). This avoids implying cross-castability between TimeType and
Date/Timestamp/TimestampNTZ that Cast.canCast doesn't actually support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
