shrirangmhalgi commented on PR #55668: URL: https://github.com/apache/spark/pull/55668#issuecomment-4457408107
Thanks @cloud-fan for the review! You're right - the literal-decimal path at `lines 884–885` has the same bug pattern. I totally missed this path. `getDecimalWritableConstantObjectInspector` hardcodes `TypeInfoFactory.decimalTypeInfo (38, 18)` regardless of the literal's actual DecimalType. I'll fix this path too in this PR to keep the change cohesive as it falls under the same JIRA and has the same root cause. Will update `toInspector(expr)` to extract `DecimalType.Fixed(precision, scale)` and pass it through to the constant inspector factory, mirroring the column-reference fix. Working on pushing a new commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
