Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6780#discussion_r32293746
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -39,11 +39,12 @@ object DefaultOptimizer extends Optimizer {
         Batch("Distinct", FixedPoint(100),
           ReplaceDistinctWithAggregate) ::
         Batch("Operator Optimizations", FixedPoint(100),
    -      UnionPushdown,
    +      UnionPushDown,
           CombineFilters,
           PushPredicateThroughProject,
           PushPredicateThroughGenerate,
           ColumnPruning,
    +      LimitPushDown,
    --- End diff --
    
    Actually I'm think of adding a test for the whole batch. As this batch is 
getting larger and larger, there are a lot more interactions between rules, we 
should make sure there is no conflict between rules and rules are all at right 
order.
    cc @marmbrus @rxin 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to