viirya commented on code in PR #55420: URL: https://github.com/apache/spark/pull/55420#discussion_r3255209033
########## connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/benchmark/RTMKafkaKafkaBenchmark.scala: ########## @@ -0,0 +1,353 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.kafka010.benchmark + +import java.nio.file.Files +import java.util.{Properties, Timer, TimerTask} +import java.util.concurrent.{CountDownLatch, TimeUnit} +import java.util.concurrent.atomic.{AtomicInteger, AtomicLong} + +import scala.concurrent.duration._ + +import org.apache.kafka.clients.producer.{Callback, KafkaProducer, Producer, ProducerRecord, RecordMetadata} + +import org.apache.spark.benchmark.{Benchmark, BenchmarkBase} +import org.apache.spark.internal.Logging +import org.apache.spark.sql.{Column, SparkSession} +import org.apache.spark.sql.execution.streaming.RealTimeTrigger +import org.apache.spark.sql.functions._ +import org.apache.spark.sql.internal.SQLConf +import org.apache.spark.sql.kafka010.KafkaTestUtils +import org.apache.spark.sql.streaming.StreamingQueryListener + +/** + * Stateless Kafka-to-Kafka RTM benchmark. Reads from an input Kafka topic, applies a + * stateless transformation, and writes results to an output Kafka topic using + * [[RealTimeTrigger]]. After the run it reports e2e latency percentiles. + * + * The benchmark spins up a real local-cluster Spark context and a live embedded Kafka + * broker, so a single run takes several minutes. + * + * To run this benchmark: + * {{{ + * 1. without sbt: + * bin/spark-submit --class <this class> + * --jars <spark core test jar>,<spark sql test jar> <spark sql kafka 0-10 test jar> + * 2. build/sbt "sql-kafka-0-10/Test/runMain <this class>" + * 3. generate result: + * SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql-kafka-0-10/Test/runMain <this class>" + * Results will be written to: + * "connector/kafka-0-10-sql/benchmarks/RTMKafkaKafkaBenchmark-results.txt". + * }}} + * + * See `benchmarks/RTMKafkaKafkaBenchmark-results.txt` for a recorded run. + */ +object RTMKafkaKafkaBenchmark extends BenchmarkBase with Logging { Review Comment: Optional: justify "why not Benchmark.run()". This is the only BenchmarkBase subclass in the repo that manually emits getJVMOSInfo() / getProcessorName() and doesn't use Benchmark.run() / Benchmark.addCase(). The reason makes sense (you're measuring a latency distribution across a streaming pipeline, not "run this synchronous function N times"), but a one-line note in the class scaladoc would save future readers a head-scratch: ``` Unlike most Spark benchmarks, this one does not use Benchmark.run(): the metric of interest is end-to-end latency percentiles across a streaming pipeline, which doesn't fit the Best/Avg/Stdev table format. Environment header is emitted manually for consistency with other result files. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
