sven-weber-db commented on code in PR #55768: URL: https://github.com/apache/spark/pull/55768#discussion_r3259492918
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExternalUserDefinedFunction.scala: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions + +import org.apache.spark.annotation.Experimental +import org.apache.spark.sql.catalyst.trees.TreePattern.{EXTERNAL_UDF, TreePattern} +import org.apache.spark.sql.types.DataType + +/** + * :: Experimental :: + * A serialized external UDF that is executed in an external worker process + * via the language-agnostic UDF worker framework. + * + * This is a Catalyst expression analogous to [[PythonUDF]] but + * language-agnostic. The [[payload]] carries an opaque serialized + * function definition whose interpretation is left to the worker. + * The optional [[inputTypes]] declare the expected argument types for + * validation during analysis; when absent, any input types are accepted. + * + * This expression is [[Unevaluable]] and requires a dedicated physical + * operator (e.g. [[org.apache.spark.sql.execution.externalUDF.MapPartitionsExternalUDFExec]]) + * to execute. + * + * @param name Name of the UDF. + * @param payload Opaque serialized function definition. + * @param dataType Return type of the UDF. + * @param children Input argument expressions. + * @param inputTypes Optional declared input types for validation. + * @param udfDeterministic Whether this UDF is deterministic. + * @param udfNullable Whether this UDF can return null. + * @param resultId Unique expression ID for this invocation. + */ +@Experimental +case class ExternalUserDefinedFunction( + name: String, Review Comment: Could you elaborate on which part specifically should be optional? For `name,` I don't think this can be optional. E.g., in `PythonUDF`, `name` is also a required string -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
