viirya commented on code in PR #55941: URL: https://github.com/apache/spark/pull/55941#discussion_r3260848934
########## sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ElementAtUtils.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions; + +import org.apache.spark.QueryContext; +import org.apache.spark.sql.errors.QueryExecutionErrors; + +/** + * Static helpers used by {@link ElementAt} on {@code ArrayType} + * (codegen and eval) under ANSI mode. + */ +public final class ElementAtUtils { + + private ElementAtUtils() {} + + /** + * Validates a 1-based {@code element_at} index against the array length + * and returns the 0-based position. Throws when the absolute index + * exceeds the array length (ANSI out-of-bounds) or when {@code index} is + * zero (always invalid). + * + * @param length the array length + * @param index the 1-based index supplied by the user (positive or negative) + * @param context the query context attached to the error + * @return the validated 0-based position + */ + public static int elementAtIndexExact(int length, int index, QueryContext context) { Review Comment: The Exact suffix is misleading. elementAtIndexExact reads like "the exact index" (i.e., as opposed to a fuzzy or default-returning variant). The actual distinction is "throws on bad input vs returns a default" — which in Spark codebase conventions is usually called …OrThrow, strict…, or just qualified by the ANSI context. elementAtIndex / resolveArrayIndex / resolveOneBasedIndex would read more naturally. Not a blocker, but the name doesn't carry its weight in a one-call-site API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
